feat(NODE-1477): Configuration revamp (IC-OS integration) #1563
+408
−692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
changed the title
andrewbattat
commented
Sep 25, 2024
ic-os/components/misc/config.sh
Outdated
Comment on lines
8
to
12
| function get_config_value() { | ||
| local CONFIG_FILE="/var/ic/config/config.json" | ||
| local key=$1 | ||
| jq -r "${key}" "${CONFIG_FILE}" | ||
| } |
There was a problem hiding this comment.
If we get a non-existant key, should we throw an error? Or just log that the key has not been found and return null?
…ration"" This reverts commit 4517b63.
andrewbattat
commented
Oct 3, 2024
Comment on lines
+26
to
+43
| match &network_settings.ipv6_config { | ||
| Ipv6Config::RouterAdvertisement => { | ||
| Err(anyhow!("IC-OS router advertisement is not yet supported")) | ||
| } | ||
| Ipv6Config::Fixed(_) => Err(anyhow!("Fixed IP configuration is not yet supported")), | ||
| Ipv6Config::Deterministic(ipv6_config) => { | ||
| let ipv6_address = generate_ipv6_address(&ipv6_config.prefix, &generated_mac)?; | ||
| eprintln!("Using ipv6 address: {}", ipv6_address); | ||
|
|
||
| let formatted_mac = FormattedMacAddress::from(&generated_mac); | ||
| generate_systemd_config_files( | ||
| output_directory, | ||
| ipv6_config, | ||
| Some(&formatted_mac), | ||
| &ipv6_address, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Note the change now that Ipv6Config is stored as an enum
… fetch-mgmt-mac.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IC-OS tool has been created, but not yet used by the IC-OS: #1539
This PR integrates the config tool into the IC-OS. The config tool is utilized for config sanitization, organization, access, and propagation.
Once we are happy with the new design, we will worry about the rollout and preserving backwards compatibility.